[Logs onboarding] Error handling in configureLogs step #162241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yngrdyn
added
the
release_note:skip
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
achyutjhunjhunwala
approved these changes
Jul 19, 2023
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.10.0
backport:skip
Ruhshan
pushed a commit
to Ruhshan/kibana
that referenced
this pull request
Jul 19, 2023
Closes elastic#156529. `Dataset name` is a field that is auto populated based on the `Log file path`, if the user deletes the autogenerated value they cannot continue with the next step but before this changes there were no indicative of why they cannot continue. ### Changes - Added validation function to datasetName field. - Added i18n error. #### Before <img width="2199" alt="image" src="https://github.com/elastic/kibana/assets/1313018/24cc166e-c143-4b35-9372-0fcdb4e78f4a"> #### After <img width="2200" alt="image" src="https://github.com/elastic/kibana/assets/1313018/72302aa6-1597-439b-8d80-88e7debf1010">
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 1, 2023
Closes elastic#156529. `Dataset name` is a field that is auto populated based on the `Log file path`, if the user deletes the autogenerated value they cannot continue with the next step but before this changes there were no indicative of why they cannot continue. ### Changes - Added validation function to datasetName field. - Added i18n error. #### Before <img width="2199" alt="image" src="https://github.com/elastic/kibana/assets/1313018/24cc166e-c143-4b35-9372-0fcdb4e78f4a"> #### After <img width="2200" alt="image" src="https://github.com/elastic/kibana/assets/1313018/72302aa6-1597-439b-8d80-88e7debf1010">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #156529.
Dataset nameis a field that is auto populated based on theLog file path, if the user deletes the autogenerated value they cannot continue with the next step but before this changes there were no indicative of why they cannot continue.Changes
Before
After